Merged
Conversation
- Add log_file, log_format, and log_level parameters to Application class - Move logging configuration from main() to Application.__init__() via _configure_logging() - Add external_function.log_file and external_function.log_format config options - Update Application docstring to document all parameters including logging - Refactor Timer.finish() to return metrics dict instead of logging directly - Configure uvicorn logging to use same log file when specified This refactoring centralizes logging configuration and allows for more flexible UDF application logging through configuration parameters. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add external_function.disable_metrics configuration option (default: False) - Add disable_metrics parameter to Application class constructor - Update Application to create logger-specific instances with unique names - Add --disable-metrics command-line argument to main function - Conditionally log metrics based on disable_metrics flag - Support configuration via environment variable SINGLESTOREDB_EXT_FUNC_DISABLE_METRICS This allows users to disable the logging of function call metrics when needed, while maintaining backward compatibility with existing behavior.
- Remove external_function.log_format configuration option and --log-format CLI flag - Standardize on JSON formatted logging for all external function applications - Add external_function.app_name configuration option with --app-name CLI flag - Change Application class constructor parameter from 'name=' to 'app_name=' for consistency - Update logging configuration to use JSON formatter for both console and file output - Improve structured logging with additional context fields (app_name, request_id, etc.) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Move uvicorn log config creation from main() into a reusable method - Allow external users to match the Application's logging format - Simplify main() by using the new method - Uses the same JSON formatter and settings as Application's internal logging 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
psachdeva-ss
approved these changes
Aug 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.